Retain Pi-hole and update chart content without rebuilding #61
No reviewers
Labels
No labels
app-migration
bug
ci-cd
cluster
Documentation
duplicate
enhancement
gpu
invalid
networking
question
security
Storage
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
Homelab/Documentation!61
Loading…
Reference in a new issue
No description provided.
Delete branch "kiyi/restore-pihole-direction"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The charts are already released and deployed, but their Markdown links select SVGs bundled inside the image. Point both chart images and full-size links directly at this repository’s public media/branch/main files. The deployed renderer already supports these URLs: merging Markdown or SVG content updates the page after refresh, with no image build, bundle release or deployment. Reconcile README, application inventory and delivery status with the owner’s 2026-10-17 confirmation and browser inspection showing both live SVGs loaded.
Retain Pi-hole across the architecture page, application inventory, decision register and overview SVG, including its accessible description. The owner cancelled Technitium in private Homelab/platform#25 on 2026-09-16 and reconfirmed the decision on 2026-10-18. Stale local workspace guidance is corrected too.
Validation: npm run check, diff checks, the existing renderer’s four absolute-URL mappings, SVG visual inspection and staged default-rule Gitleaks 8.30.1 pass. Forgejo’s direct SVG endpoint renders in the browser. Published blobs and both kiyi commit identities are verified. npm run build still hits the existing local Turbopack CSS subprocess error; hosted checks remain required. No application code, workflows or infrastructure change, and no manual workflow was dispatched.
Tracks #56.
Reviewed the exact head's four changed files: applications inventory, architecture DNS boundary, decision register, and overview SVG (including accessible description) consistently retain Pi-hole for LAN split DNS/ad blocking and remove the planned Technitium replacement. The change is documentation/diagram only; it does not modify UDS deployment, admission policy, gateways, or routes. Source review has no blocking findings. The changed-files endpoint omitted patch hunks, so I inspected each complete changed file at this SHA; I did not independently verify the private owner-decision comment or visually rasterize the SVG. Documentation-site and source-security checks are still pending; this approval is not CI acceptance, a released bundle, a live-site correction, or merge authorization.
CI at submission: pending. This is a source-review approval, not a scan verdict; required checks still block merge.
Restore the owner decision to retain Pi-holeto Retain Pi-hole and update chart content without rebuildingReviewed all six changed files at the authenticated exact head. The README, applications inventory, architecture DNS boundary, decision register and overview SVG (including accessible description) consistently retain Pi-hole and reject the superseded Technitium migration. The architecture page now links its diagrams via the public Forgejo media/branch/main URLs; the README, inventory and delivery record consistently describe Markdown/SVG refresh from reviewed main without an image/bundle rebuild, while keeping application-code/layout changes on the signed release path. This PR changes documentation and diagram content only, not UDS package, admission, gateway, route or scanner configuration; no source blocker found. Forgejo's changed-files response omitted patch hunks, so this assessment uses the exact-head full contents and the prior head-bound review; I could not independently compare base hunks, inspect the private owner-decision comment, rasterize the SVG, or validate the live renderer/browser. Source security and documentation-site checks remain pending; approval does not constitute CI acceptance, deployment or merge authorization.
CI at submission: pending. This is a source-review approval, not a scan verdict; required checks still block merge.
Reviewed all six changed files at the exact head. README, architecture, applications and delivery notes consistently describe the existing deployed chart versus future content updates; both architecture chart image/full-size links target this repository's public main-branch SVGs, and the overview diagram and accessible description retain Pi-hole for split DNS/ad blocking. The decision register and DNS boundary agree. These are documentation/SVG changes only: no UDS package, policy/admission, deployment manifest, gateway or route is changed, so there is no new UDS deployment boundary or ghost bundle to require. No source-review blockers. The changed-files API omitted patch hunks; I inspected the changed files' head contents and the prior review rather than claiming a complete base diff, rendered-site validation, visual raster inspection, or independent verification of the private owner-decision evidence. Source-security and Documentation site checks remain pending at this head; this approval is not CI/scan acceptance or merge authorization.
CI at submission: pending. This is a source-review approval, not a scan verdict; required checks still block merge.