fix(delivery): allow large release assets to finish processing #50

Merged

gitchegumi merged 1 commit from kiyi/release-upload-timeout into main

2026-09-20 18:13:18 -05:00

kiyi commented

2026-09-20 18:06:12 -05:00

Member

Keep the existing 300-second connection/send timeout and switch the connected socket to a 1800-second read timeout after sending the full multipart body. Log the transition to waiting for Forgejo, and close the connection on both success and failure. HTTP errors still block publication; no automatic POST retry is added because a timed-out request may already have created the asset. The overall job deadline remains unchanged.

Validation: 168 Linux regression tests pass, including upload success, HTTP rejection and response timeout, multipart size/content, timeout ordering, one POST and connection cleanup. git diff --check passes. Rebound one existing self-scan exception only because the health-check call moved lines; its scope/expiry are unchanged. Added proxy/Forgejo log locations to the delivery guide.

This corrects the client’s premature timeout; it does not establish why Forgejo/proxy processing takes longer than five minutes. A full-size live release upload remains to be verified after releasing and adopting this fix. Related: Homelab/Comfy-UI#1 and #5.

ComfyUI run 141 sent the release asset body, then the uploader timed out waiting for the HTTP response. HTTPSConnection used a 300-second timeout even though the owner’s NPM read timeout is 1800 seconds. Keep the existing 300-second connection/send timeout and switch the connected socket to a 1800-second read timeout after sending the full multipart body. Log the transition to waiting for Forgejo, and close the connection on both success and failure. HTTP errors still block publication; no automatic POST retry is added because a timed-out request may already have created the asset. The overall job deadline remains unchanged. Validation: 168 Linux regression tests pass, including upload success, HTTP rejection and response timeout, multipart size/content, timeout ordering, one POST and connection cleanup. git diff --check passes. Rebound one existing self-scan exception only because the health-check call moved lines; its scope/expiry are unchanged. Added proxy/Forgejo log locations to the delivery guide. This corrects the client’s premature timeout; it does not establish why Forgejo/proxy processing takes longer than five minutes. A full-size live release upload remains to be verified after releasing and adopting this fix. Related: Homelab/Comfy-UI#1 and #5.

kiyi added 1 commit

2026-09-20 18:06:12 -05:00

fix(delivery): allow large release assets to finish processing

Workflow acceptance / acceptance (pull_request) Successful in 2m44s

Details

Library checks / tests (pull_request) Successful in 3m56s

Details

Repository security / security-1 (pull_request) Successful in 6m13s

Details

Repository security / security (pull_request) Successful in 0s

Details

dc117fe48c