Homelab/workflows
Homelab/workflows
Watch
5
0
Fork
You've already forked workflows
 0
Code Issues 7 Pull requests Projects Releases 95 Packages Wiki Activity Actions

fix(delivery): check storage before downloading deployment bundles #52

Merged
gitchegumi merged 1 commit from kiyi/storage-preflight into main 2026-09-21 15:28:24 -05:00
Conversation 1 Commits 1 Files changed 8 +358 -17
kiyi commented 2026-09-21 00:00:18 -05:00
Member
Copy link

ComfyUI deployment waited through Helm timeouts because its local StorageClass and PVs were missing. Both shared deployment entry points now verify signed manifest metadata and check the selected environment’s PVC/PV prerequisites before downloading the large bundle or rescanning images.

Checks cover referenced claims, static PV compatibility/reservations, dynamic provisioning (including WaitForFirstConsumer), and StatefulSet claim templates. No storage resources are created. Host paths, CSI health and scheduling remain rollout checks. Existing signed bundles remain usable.

Validation: all 182 workflow tests pass locally, including missing ComfyUI storage and early failure before archive download; git diff --check passes. Not deployed.

Adoption prerequisite: reconcile platform deployment identities with get/list permissions for PVs and StorageClasses before adopting this workflow release. Legacy identities need the same read permissions. Related: #5, Homelab/Comfy-UI#1.

ComfyUI deployment waited through Helm timeouts because its local StorageClass and PVs were missing. Both shared deployment entry points now verify signed manifest metadata and check the selected environment’s PVC/PV prerequisites before downloading the large bundle or rescanning images. Checks cover referenced claims, static PV compatibility/reservations, dynamic provisioning (including WaitForFirstConsumer), and StatefulSet claim templates. No storage resources are created. Host paths, CSI health and scheduling remain rollout checks. Existing signed bundles remain usable. Validation: all 182 workflow tests pass locally, including missing ComfyUI storage and early failure before archive download; git diff --check passes. Not deployed. Adoption prerequisite: reconcile platform deployment identities with get/list permissions for PVs and StorageClasses before adopting this workflow release. Legacy identities need the same read permissions. Related: #5, Homelab/Comfy-UI#1.
fix(delivery): check storage before downloading deployment bundles
All checks were successful
Workflow acceptance / acceptance (pull_request) Successful in 3m6s
Details
Repository security / security-1 (pull_request) Successful in 3m18s
Details
Repository security / security (pull_request) Successful in 0s
Details
Library checks / tests (pull_request) Successful in 3m32s
Details
576b38b71b
gitchegumi approved these changes 2026-09-21 15:28:20 -05:00
gitchegumi deleted branch kiyi/storage-preflight 2026-09-21 15:28:25 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
gitchegumi
Labels
Clear labels
  
app-migration

   
bug
Something is not working

  
ci-cd

   
cluster

   
Documentation

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
gpu

   
invalid
Something is wrong

  
networking

   
question
More information is needed

  
security

   
Storage

   
wontfix
This won't be fixed

No labels
app-migration
bug
ci-cd
cluster
Documentation
duplicate
enhancement
gpu
invalid
networking
question
security
Storage
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Homelab/workflows!52
No description provided.